[PATCH] D69903: [Basic] Introduce PODSourceLocation, NFCI
Duncan P. N. Exon Smith via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Oct 19 14:36:24 PDT 2020
dexonsmith requested changes to this revision.
dexonsmith added a comment.
This revision now requires changes to proceed.
An alternative would be to update the unions to an `AlignedCharArrayUnion` and use `SourceLocation` directly. WDYT?
================
Comment at: clang/include/clang/AST/DeclObjC.h:652-655
struct PODSourceRange {
- unsigned Begin;
- unsigned End;
+ PODSourceLocation Begin;
+ PODSourceLocation End;
};
----------------
IIRC, this will not be a POD, since the access of the members of `PODSourceRange` is `public` and the access of the members of `PODSourceLocation` is `private`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69903/new/
https://reviews.llvm.org/D69903
More information about the cfe-commits
mailing list