[PATCH] D89719: [clang][Basic] Make SourceLocation usable as key in hash maps, NFCI

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 19 14:21:01 PDT 2020


dexonsmith requested changes to this revision.
dexonsmith added a comment.
This revision now requires changes to proceed.

We don't usually add code without any current users. I suggest either adding a small unit test proving `SourceLocation` can now be used as a `DenseMap` key (probably preferred) or converting one `DenseMap` over so that it at least has one use.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89719/new/

https://reviews.llvm.org/D89719



More information about the cfe-commits mailing list