[PATCH] D89430: clang/Basic: Remove SourceManager::getBufferPointer, NFC

Jonas Devlieghere via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 19 12:14:57 PDT 2020


JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: clang/lib/Basic/SourceManager.cpp:167
 
     Buffer.setInt(Buffer.getInt() | InvalidFlag);
+    return None;
----------------
Orthogonal to this patch but an idea for a follow-up: this seems lightly error prone and repetitive. We could put it in an `llvm::scope_exit` and then release it before the final return on line `200`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89430/new/

https://reviews.llvm.org/D89430



More information about the cfe-commits mailing list