[PATCH] D89579: [clangd][ObjC] Support nullability annotations

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 19 07:48:50 PDT 2020


sammccall added inline comments.


================
Comment at: clang-tools-extra/clangd/Selection.cpp:611
+      // robust.
+      return false;
     if (!SelChecker.mayHit(S)) {
----------------
I'm not sure we actually want to *do it* at this point, as you're seeing we may have some unintended consequences.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89579/new/

https://reviews.llvm.org/D89579



More information about the cfe-commits mailing list