[PATCH] D86936: [clang] Limit the maximum level of fold-expr expansion.

[Erich Keane via Phabricator via cfe-commits]

erichkeane added subscribers: rjmccall, erichkeane.
erichkeane added a comment.

Why did we select the 'bracket-depth' for this?  The documentation on that doesn't seem to be anything close to what this should be based on:

  Sets the limit for nested parentheses, brackets, and braces to N in blocks, declarators, expressions, and struct or union declarations.

The 256 default limit is REALLY small for a fold expression, particularly since the instantiation depth limit is 1024 by default.  I think this patch needs to be changed to use the InstantiationDepth instead.  @rjmccall, thoughts?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86936/new/

https://reviews.llvm.org/D86936