[PATCH] D89394: clang/Basic: Stop using SourceManager::getBuffer, NFC

[Nikita Popov via Phabricator via cfe-commits]

nikic added a comment.

FYI this showed up as a 1% compile-time regression in terms of instructions retired for `O0-g` builds: https://llvm-compile-time-tracker.com/compare.php?from=32a4ad3b6ce6028a371b028cf06fa5feff9534bf&to=54c1bcab90102481fe43b73f8547d47446ba2163&stat=instructions

Looking at the diff, it's not really obvious to me what could cause that, possibly GCC is just really bad at optimizing Optional<MemoryBufferRef>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89394/new/

https://reviews.llvm.org/D89394