[PATCH] D89573: [Driver] Incorporate -mfloat-abi in the computed triple on ARM

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 16 14:07:59 PDT 2020


efriedma added inline comments.


================
Comment at: clang/lib/Driver/ToolChain.cpp:807
+    default:
+      break;
+    }
----------------
Do we want to error in the "default" case?  Not that anyone is likely to use -mfloat-abi on those targets, but I'd prefer not to silently miscompile.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89573/new/

https://reviews.llvm.org/D89573



More information about the cfe-commits mailing list