[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

Nick Desaulniers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 16 11:16:49 PDT 2020


nickdesaulniers requested changes to this revision.
nickdesaulniers added a comment.
This revision now requires changes to proceed.

Thanks for updating the patch.

Please add a test case for the earlyclobber case. In particular, if none of the in-tree tests failed for the initial version of this patch that landed, you should add one that would have.

I should be able to `git checkout c78da037783bda0f27f4d82060149166e6f0c796`, observe the test case fail, then `arc patch D87279` and observe the test case pass.

The current version of this patch,  Diff 298624, passes the previously failing Linux kernel builds.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87279/new/

https://reviews.llvm.org/D87279



More information about the cfe-commits mailing list