[PATCH] D89487: [AMDGPU] gfx1032 target

Jay Foad via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 16 09:15:38 PDT 2020


foad added inline comments.


================
Comment at: llvm/docs/AMDGPUUsage.rst:280
                                                                                  names.
+     ``gfx1032``                 ``amdgcn``   dGPU  - xnack                   *TBA*
+                                                      [off]
----------------
xnack looks like a mistake here?


================
Comment at: llvm/lib/Support/TargetParser.cpp:66
 // Don't bother listing the implicitly true features
-constexpr GPUInfo AMDGCNGPUs[43] = {
+constexpr GPUInfo AMDGCNGPUs[44] = {
   // Name         Canonical    Kind        Features
----------------
Use `[]` so we don't have to keep updating the number?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89487/new/

https://reviews.llvm.org/D89487



More information about the cfe-commits mailing list