[PATCH] D89332: [clang-tidy] performance-unnecessary-copy-initialization: Always allow std::function to be copied.

Thu Oct 15 23:19:45 PDT 2020

lebedev.ri added inline comments.

================
Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:52
       AllowedTypes(
           utils::options::parseStringList(Options.get("AllowedTypes", ""))) {}

----------------
flx wrote:
> lebedev.ri wrote:
> > Just put it here?
> I tried this first, but this list  is substring matched against only on the non-qualified type name, so std::function would not match anything and if we added "function" here it would match many other types that contain the word function.
I would personally say it's a bug, especially because i personally don't like hardcoded "choices" that are impossible to change.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89332/new/

https://reviews.llvm.org/D89332