[PATCH] D89508: SourceManager: getFileEntryRefForID => getNonBuiltinFilenameForID, NFC

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 15 16:14:59 PDT 2020


dexonsmith added inline comments.


================
Comment at: clang/lib/Basic/SourceManager.cpp:729-730
   if (const SrcMgr::SLocEntry *Entry = getSLocEntryForFile(FID))
     if (auto *Content = Entry->getFile().getContentCache())
       if (Content && Content->OrigEntry)
+        return Entry->getFile().getName();
----------------
These `if`s need to stay behind to detect whether the file is built-in.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89508/new/

https://reviews.llvm.org/D89508



More information about the cfe-commits mailing list