[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

[John McCall via Phabricator via cfe-commits]

rjmccall added a comment.

Thanks, this looks a lot better.



================
Comment at: clang/include/clang/Basic/Diagnostic.h:1065
+///
+class StreamableDiagnosticBase {
+public:
----------------
I think I would prefer `StreamingDiagnostic` as the class name here.


================
Comment at: clang/include/clang/Basic/PartialDiagnostic.h:66
+    return *this;
+  }
+
----------------
Why are these template operators necessary?  The LHS of the `<<` should convert to a base reference type just fine.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84362/new/

https://reviews.llvm.org/D84362