[PATCH] D89372: [OpenCL] Remove unused extensions
Yaxun Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 14 13:10:15 PDT 2020
yaxunl added inline comments.
================
Comment at: clang/include/clang/Basic/OpenCLExtensions.def:16
//
// If the extensions are to be enumerated without the supported OpenCL version,
// define OPENCLEXT(ext) where ext is the name of the extension.
----------------
Can you add a comment here referring the spec about "Every extension which affects the OpenCL language semantics, syntax or adds built-in functions to the language must create a preprocessor #define that matches the extension name string." and therefore only extensions "which affects the OpenCL language semantics, syntax or adds built-in functions to the language" are defined in this file. Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89372/new/
https://reviews.llvm.org/D89372
More information about the cfe-commits
mailing list