[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 14 11:08:24 PDT 2020


tra added inline comments.


================
Comment at: clang/include/clang/Basic/PartialDiagnostic.h:51
+      : DiagID(DiagID) {
+    Allocator = &Allocator_;
+  }
----------------
Is there a particular reason to move field initialization into the body here and in other constructors?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84362/new/

https://reviews.llvm.org/D84362



More information about the cfe-commits mailing list