[PATCH] D89220: [clang-rename] Simplify the code of handling class paritial specializations, NFC.

Danila Malyutin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 14 05:04:51 PDT 2020


danilaml added inline comments.


================
Comment at: clang/lib/Tooling/Refactoring/Rename/USRFindingAction.cpp:119
+    llvm::for_each(PartialSpecs,
+                   [&](const auto *Spec) { addUSRsOfCtorDtors(Spec); });
     addUSRsOfCtorDtors(TemplateDecl->getTemplatedDecl());
----------------
Btw, this breaks on GCC <= 7.1, due to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67274
Workaround is to use `this->`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89220/new/

https://reviews.llvm.org/D89220



More information about the cfe-commits mailing list