[PATCH] D89303: [SyntaxTree] Improve safety of `replaceChildRangeLowLevel`

Eduardo Caldas via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 14 02:42:11 PDT 2020


eduucaldas marked an inline comment as done.
eduucaldas added inline comments.


================
Comment at: clang/lib/Tooling/Syntax/Tree.cpp:122
 #endif
+  Node *&Begin = BeforeBegin ? BeforeBegin->NextSibling : FirstChild;
+
----------------
gribozavr2 wrote:
> Could you move this definition up so that it can be used in the last assert above?
Done in a separate commit: 6fbad9bf304c05d37454420f7d5a1c2ab3adab20


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89303/new/

https://reviews.llvm.org/D89303



More information about the cfe-commits mailing list