[PATCH] D78699: [X86] Passing union type through register.

LiuChen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 13 18:41:25 PDT 2020


LiuChen3 added a comment.

In D78699#2328541 <https://reviews.llvm.org/D78699#2328541>, @dyung wrote:

> Hi, the test you added seems to pass both before and after your change, is this intended?

Oh, yes. I made mistake on my RUN line. So these tests are not really checked. Thanks for your help!
I will make another patch to fix this testcase.



================
Comment at: clang/test/CodeGen/X86/avx-union.c:22
+union M512 m2;
+// CHECK-LABEL: define dso_local void @test()
+// CHECK:       void @foo1(<4 x double>
----------------
dyung wrote:
> When I fix the run lines above, I'm not getting "dso_local". Might want to double check that.
There actually have no 'dso_local'. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78699/new/

https://reviews.llvm.org/D78699



More information about the cfe-commits mailing list