[PATCH] D78658: [clang][Frontend] Add missing error handling
David Blaikie via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 13 17:38:03 PDT 2020
dblaikie accepted this revision.
dblaikie added inline comments.
================
Comment at: clang/lib/Frontend/ASTUnit.cpp:1158-1160
+ if (!Clang->hasTarget()) {
return true;
+ }
----------------
You can remove these braces now - since it's a superfluous change here now there's no need to add an extra function call.
================
Comment at: clang/lib/Frontend/ASTUnit.cpp:1217-1219
+ if (!Act->BeginSourceFile(*Clang.get(), Clang->getFrontendOpts().Inputs[0])) {
+ return true;
+ }
----------------
Skip the braces here, since it's a single-line scope.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78658/new/
https://reviews.llvm.org/D78658
More information about the cfe-commits
mailing list