[PATCH] D89184: Support complex target features combinations

Tue Oct 13 11:17:19 PDT 2020

tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.

In D89184#2328144 <https://reviews.llvm.org/D89184#2328144>, @craig.topper wrote:

> This is needed for D89105 <https://reviews.llvm.org/D89105> and was split from it.

D89105 <https://reviews.llvm.org/D89105>  appears to use only `"avx512vl , avx512vnni | avxvnni"`.
Does it mean `(avx512vl , avx512vnni) | avxvnni` or `avx512vl , (avx512vnni | avxvnni)` ?

This change would be needed for the former, but not the latter. I assume that it's the former. If that's the case, LGTM.
Caveat: I'm not the owner of CodeGen, so you may want to give someone familiar with it a chance to chime in before landing the change.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89184/new/

https://reviews.llvm.org/D89184