[PATCH] D89318: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex
Shafik Yaghmour via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 13 10:05:28 PDT 2020
shafik accepted this revision.
shafik added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: clang/lib/AST/ASTImporter.cpp:8109
+ FromAttr->getAttributeSpellingListIndex());
+ ToAttr->setPackExpansion(FromAttr->isPackExpansion());
+ ToAttr->setImplicit(FromAttr->isImplicit());
----------------
Why move these two but not `setInherited(...)` it is not really explained in the description.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89318/new/
https://reviews.llvm.org/D89318
More information about the cfe-commits
mailing list