[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

Adrian McCarthy via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 13 09:22:12 PDT 2020


If I had to guess, my money would be on a deadlock.  To unblock, I'd
propose reverting this patch until we can figure it out.

During the review, a deadlock was fixed related to the watcher thread, but
perhaps we missed one for the notifier thread.

On Tue, Oct 13, 2020 at 8:40 AM Hans Wennborg via Phabricator <
reviews at reviews.llvm.org> wrote:

> hans added a comment.
>
> The longer timeout didn't help :(
>
> I'm not sure what's different about the machine where this is failing.
> Maybe it's some filesystem issue due to being a VM?
>
> Any ideas for good printfs or similar that could be added to figure out
> exactly what part is failing?
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D88666/new/
>
> https://reviews.llvm.org/D88666
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201013/a4089886/attachment.html>


More information about the cfe-commits mailing list