[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

Mon Oct 12 13:40:11 PDT 2020

Szelethus added a subscriber: aaron.ballman.
Szelethus added inline comments.

================
Comment at: clang/lib/Analysis/SarifPathDiagnosticConsumer.cpp:307
   .Case(FULLNAME, HELPTEXT)
 #include "clang/StaticAnalyzer/Checkers/Checkers.inc"
 #undef CHECKER
----------------
NoQ wrote:
> Szelethus wrote:
> > NoQ wrote:
> > > This thing still worries me but this definitely isn't a link-time dependency.
> > D53277#1285757, rGb8cfcc71469d40a98f4cc79fcdc46cd67bea45f7
> Ok, what's the proper solution here? This is clearly a layering violation now; this generic diagnostic consumer shouldn't know anything about the Static Analyzer specifically. I guess we could separate it into an independent polymorphic object ("DescriptionGetter" or something like that) that the Static Analyzer would instantiate manually. Or ideally we could ship this information with the bug report itself.
> 
> I'll add a FIXME and try to reproduce potential modules problems locally.
I am puzzled myself :/ Maybe we could ask @aaron.ballman, since he landed most of these changes back in the day?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67422/new/

https://reviews.llvm.org/D67422