[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

CJ Johnson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 12 11:57:59 PDT 2020


CJ-Johnson added inline comments.


================
Comment at: clang/lib/CodeGen/CGCall.cpp:2174
+  }
+
   unsigned ArgNo = 0;
----------------
jdoerfert wrote:
> Even if null pointer is valid we should place dereferenceable.
> 
> We also could never place nonnull and let the middle-end make the dereferenceable -> nonnull deduction, though I don't see why we can't just add nonnull here.
I re-ran ninja check after making this fix and addressed the newly-affected tests. So the patch is fully up to date :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D17993/new/

https://reviews.llvm.org/D17993



More information about the cfe-commits mailing list