[PATCH] D89198: [X86] Define __LAHF_SAHF__ if feature 'sahf' is set

[Craig Topper via Phabricator via cfe-commits]

craig.topper added inline comments.


================
Comment at: clang/lib/Basic/Targets/X86.cpp:564
+  if (HasLAHFSAHF)
+    Builder.defineMacro("__LAHF_SAHF__");
   if (HasLZCNT)
----------------
craig.topper wrote:
> It looks like gcc may define this always in 32-bit mode?
More confusingly, they define it in 32-bit mode unless -mno-sahf is on the command line. Despite 32-bit mode always having LAHF/SAHF instructions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89198/new/

https://reviews.llvm.org/D89198