[PATCH] D89194: [clang-tidy] Fix crash in readability-function-cognitive-complexity on weak refs
Nathan James via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sat Oct 10 17:34:10 PDT 2020
njames93 added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp:504
Finder->addMatcher(
- functionDecl(
- allOf(isDefinition(), unless(anyOf(isDefaulted(), isDeleted(),
- isImplicit(), isInstantiated()))))
+ functionDecl(allOf(isDefinition(),
+ unless(anyOf(isDefaulted(), isDeleted(), isImplicit(),
----------------
Not strictly necessary but that `allOf`can be removed. All top level matchers are Implicit allOf matchers.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89194/new/
https://reviews.llvm.org/D89194
More information about the cfe-commits
mailing list