[PATCH] D88659: [FE]Split SuitableAlign into two parts

Sat Oct 10 14:27:13 PDT 2020

hubert.reinterpretcast added a comment.

In D88659#2323631 <https://reviews.llvm.org/D88659#2323631>, @jyknight wrote:

> ISTM that comment may be incorrect. At least, the precedent set by GCC appears to be that BIGGEST_ALIGNMENT and alloca _both_ should follow vector alignment requirements of the selected ISA even when that is greater than any fundamental alignment requirement, and greater than malloc's alignment.

That would make sense. I guess this is really the alloca alignment value then? We can change the scope of this patch to simply correct the comment and add another patch to update the value on AIX to be 16. Do you believe the change to the "definition" of `SuitableAlign` needs a note to the mailing list?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88659/new/

https://reviews.llvm.org/D88659