[PATCH] D88477: [analyzer] Overwrite cast type in getBinding only if that was null originally

Sat Oct 10 06:57:16 PDT 2020

steakhal added a comment.

In D88477#2319959 <https://reviews.llvm.org/D88477#2319959>, @ASDenysPetrov wrote:

> @NoQ @steakhal
>
> Hi, guys.
>
> I've just uploaded a patch for solving this and related D77062 <https://reviews.llvm.org/D77062>. Welcome to review D89055 <https://reviews.llvm.org/D89055>.

Abandoning in favor of D89055 <https://reviews.llvm.org/D89055>.
@ASDenysPetrov, please try to add the mentioned assertion into the `RegionStoreManager::getBinding` to make sure our invariant holds.

About the D77062 <https://reviews.llvm.org/D77062>, I think any NFC refactor is more then welcomed. Let's discuss about that after the fix landed.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88477/new/

https://reviews.llvm.org/D88477