[PATCH] D88968: [WebAssembly] Prototype i16x8.q15mulr_sat_s

[Thomas Lively via Phabricator via cfe-commits]

tlively added inline comments.


================
Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:117
 
+TARGET_BUILTIN(__builtin_wasm_q15mulr_saturate_s_i8x16, "V8UsV8UsV8Us", "nc", "simd128")
+
----------------
aheejin wrote:
> - Is it implemented in the VM? If not shouldn't we use `unimplemented-simd128`?
> - Are the args and the result unsigned?
Instead of using `unimplemented-simd128`, we're protecting users from accidentally using this instruction by making it opt-in via the builtin function. If they don't explicitly write the builtin, they won't get the instruction.

Good point about the sign of the arguments. They should be signed and I will fix that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88968/new/

https://reviews.llvm.org/D88968