[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

Jason Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 9 10:29:49 PDT 2020


jasonliu added a comment.

In D88737#2321921 <https://reviews.llvm.org/D88737#2321921>, @MaskRay wrote:

> A less intrusive approach is to not touch the existing InitTargetOptionsFromCodeGenFlags without parameters. You can add an `initTargetOptionsFromCodeGenFlags` with `const Tripe &` as its parameter.

I thought about that. But would prefer people think about whether or not a proper Triple is actually needed in that scenario before they make a call to `InitTargetOptionsFromCodeGenFlags`. 
Have an `InitTargetOptionsFromCodeGenFlags` without parameter, or has Triple() as default parameter could potentially results in people choose the wrong one to call because it's just more convenient.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88737/new/

https://reviews.llvm.org/D88737



More information about the cfe-commits mailing list