[PATCH] D88414: [clangd] Introduce memory dumping to FileIndex, FileSymbols and BackgroundIndex

[Sam McCall via Phabricator via cfe-commits]

sammccall added a comment.

In D88414#2319161 <https://reviews.llvm.org/D88414#2319161>, @kadircet wrote:

> In D88414#2317106 <https://reviews.llvm.org/D88414#2317106>, @sammccall wrote:
>
>> Now there's lots of usage (which looks good!) i'm finding it a bit hard to keep track of what the tree will look like overall.
>>
>> At some point it'd be great to:
>>  a) bind this to an LSP extension so we can see it in editors
>
> i was also thinking about it and couldn't decide between a "custom command" vs "code action".
>
> - the former gives a richer interaction, but requires every editor plugin to implement support.
> - the latter is a little bit more restrictive but doesn't require a bunch of extra work.
>
> I am happy to go with the "code action" approach initially. WDYT? (not in the scope of this patch)

I'm pretty leery about code action because it's not at all context-sensitive (not even per-file).
That also doesn't give us any way to specify detail vs summary if we want that.
I'd suggest a custom LSP method (unless there's some reason to prefer `executeCommand`? Seems like additional indirection for no benefit).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88414/new/

https://reviews.llvm.org/D88414