[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

Amy Huang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 8 14:35:41 PDT 2020


akhuang added a comment.

In D89072#2320209 <https://reviews.llvm.org/D89072#2320209>, @dblaikie wrote:

> I'll probably leave the llvm/CodeView parts of this for @rnk - but for the clang parts, they should have corresponding clang test coverage & I'd be curious to see the test for that to understand what the IR was before/after this change. (& to understand if/how either of those differ from the DWARF IR)

Oh, I forgot to update the clang tests. The clang change reverts https://reviews.llvm.org/D62167, which made the IR for CodeView different (adding DIGlobalVariables for static members).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89072/new/

https://reviews.llvm.org/D89072



More information about the cfe-commits mailing list