[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

Amy Huang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 8 13:58:47 PDT 2020


akhuang created this revision.
akhuang added reviewers: rnk, dblaikie.
Herald added subscribers: llvm-commits, cfe-commits, hiraditya.
Herald added projects: clang, LLVM.
akhuang requested review of this revision.

We used to only emit static const data members in CodeView as
S_CONSTANTS when they were used; this patch makes it so they are always emitted.

I changed CodeViewDebug.cpp to find the static const members from the
class debug info instead of creating DIGlobalVariables in the IR 
whenever a static const data member is used.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D89072

Files:
  clang/lib/CodeGen/CGDebugInfo.cpp
  llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
  llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.h
  llvm/test/DebugInfo/COFF/global-constants.ll
  llvm/test/DebugInfo/COFF/types-array-unsized.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89072.297048.patch
Type: text/x-patch
Size: 16887 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201008/a63f0680/attachment-0001.bin>


More information about the cfe-commits mailing list