[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 8 09:17:50 PDT 2020


aaron.ballman added inline comments.


================
Comment at: clang/lib/CodeGen/CGStmt.cpp:2095
+    if (!GCCReg.empty() && !PhysRegOutputs.insert(GCCReg).second)
+      CGM.Error(S.getAsmLoc(), "Multiple outputs to hard register: " + GCCReg);
+
----------------
Diagnostics in Clang are typically not grammatically correct, so I think it should be `multiple` instead of `Multiple`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87279/new/

https://reviews.llvm.org/D87279



More information about the cfe-commits mailing list