[PATCH] D88659: [FE]Split SuitableAlign into two parts

James Y Knight via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 7 15:56:43 PDT 2020


jyknight added a comment.

> As you mentioned, without this patch, `SuitableAlign` is used for the predefined `__BIGGEST_ALIGNMENT__` and alignment for alloca. But on AIX, the __BIGGEST_ALIGNMENT__ should be 8bytes,  alloca and `__attribute__((aligned))`  should align to 16bytes considering vector types which have to be aligned to 16bytes, that's why we want to split `SuitableAlign` following current Clang state. We'd like to split something out to consider vector type alignment.

It seems like on AIX, `__BIGGEST_ALIGNMENT__` should just be set to 16, then. I'm not sure why you want it to be 8?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88659/new/

https://reviews.llvm.org/D88659



More information about the cfe-commits mailing list