[PATCH] D88643: [NFC] Correct name of profile function to Profile in APValue
Richard Smith - zygoloid via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 7 12:19:44 PDT 2020
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Good idea. (My use for this in class type non-type template parameters doesn't directly use `APValue`s as values in a folding set, but that seems like a reasonable use case for this functionality.)
================
Comment at: clang/include/clang/AST/APValue.h:366-367
/// Profile this value. There is no guarantee that values of different
- /// types will not produce the same profiled value, so the type should
- /// typically also be profiled if it's not implied by the context.
- void profile(llvm::FoldingSetNodeID &ID) const;
+ /// types will not produce the same Profiled value, so the type should
+ /// typically also be Profiled if it's not implied by the context.
+ void Profile(llvm::FoldingSetNodeID &ID) const;
----------------
These ones shouldn't be capitalized :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88643/new/
https://reviews.llvm.org/D88643
More information about the cfe-commits
mailing list