[PATCH] D87451: add new option -mignore-xcoff-visibility
Digger via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 7 12:01:40 PDT 2020
DiggerLin marked an inline comment as done.
DiggerLin added inline comments.
================
Comment at: llvm/include/llvm/Target/TargetOptions.h:126
FunctionSections(false), DataSections(false),
- UniqueSectionNames(true), UniqueBasicBlockSectionNames(false),
- TrapUnreachable(false), NoTrapAfterNoreturn(false), TLSSize(0),
- EmulatedTLS(false), ExplicitEmulatedTLS(false), EnableIPRA(false),
+ IgnoreXCOFFVisibility(false), UniqueSectionNames(true),
+ UniqueBasicBlockSectionNames(false), TrapUnreachable(false),
----------------
jasonliu wrote:
> Should the default be true for this option?
> As this is an XCOFF only option, and the default for clang is true, so it would be better for llc to match as well?
we can implement it in another separate patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87451/new/
https://reviews.llvm.org/D87451
More information about the cfe-commits
mailing list