[PATCH] D88363: [CodeGen] Improve likelihood attribute branch weights

Mark de Wever via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 7 10:17:48 PDT 2020


Mordante added a comment.

In D88363#2312129 <https://reviews.llvm.org/D88363#2312129>, @jmorse wrote:

> Hi -- We (Sony) are running into a bit of difficulty with the test for this change, as it relies on the configuration of the -O1 optimisation pipeline. Would it be possible to reduce down to a frontend test, and then tests for whatever passes are to interpret the IR produced by clang?

Can you explain the kind of issues you're having?
Currently the code, like PGO, requires at least `-O1` to be effective. At `-O0` the attributes don't have any effect.
I looked at other CodeGen tests using `__builtin_expect`. They are using `-O1 -disable-llvm-passes`, would that solve your issue?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88363/new/

https://reviews.llvm.org/D88363



More information about the cfe-commits mailing list