[PATCH] D17053: [libcxx]: vector: Use < instead of != to improve failure mode

Louis Dionne via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 7 05:50:22 PDT 2020


ldionne added a comment.

Also, regarding `allocator::pointer` vs raw pointers -- if someone defines a fancy pointer type whose `operator<` is significantly more costly than `operator!=`, I think this loop in libc++ is not the first thing that's going to bite them. I don't think that's the right motive to drop this patch, instead I think it's about the debug mode like I explained above.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D17053/new/

https://reviews.llvm.org/D17053



More information about the cfe-commits mailing list