[PATCH] D88956: [clang-format] Fix misformatted macro definitions after D86959

Manuel Klimek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 7 05:28:12 PDT 2020


klimek added inline comments.


================
Comment at: clang/unittests/Format/FormatTest.cpp:8333
 
+TEST_F(FormatTest, UnderstandsUsesOfStarAndAmpInMacroDefinition) {
+  // This is a regression test for mis-parsing the & after decltype as a binary
----------------
I'd put this into a new test file that specifically tests annotations, perhaps AnnotationTest.cpp?

Also, the test name seems misleading, as not all of these are macro definitions?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88956/new/

https://reviews.llvm.org/D88956



More information about the cfe-commits mailing list