[PATCH] D86959: [clang-format] Fix formatting of _Atomic() qualifier

Alexander Richardson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 7 04:35:32 PDT 2020


arichardson added a comment.

In D86959#2316351 <https://reviews.llvm.org/D86959#2316351>, @arichardson wrote:

> In D86959#2313631 <https://reviews.llvm.org/D86959#2313631>, @sammccall wrote:
>
>> Sorry to be really late here, but this patch regressed some macro definitions like:
>>
>>   #define lambda [](const decltype(x) &ptr) {}
>>
>> which now formats as
>>
>>   #define lambda [](const decltype(x) & ptr) {}
>>
>> (extra space around ampersand)
>>
>> It looks like the generalization of decltype into a tokentype on the parens isn't catching all the cases it used to.
>> This isn't really my area - any idea why this might be?
>
> I did some debugging (see D88952 <https://reviews.llvm.org/D88952>) and should have a fix shortly.

D88956 <https://reviews.llvm.org/D88956> should fix this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86959/new/

https://reviews.llvm.org/D86959



More information about the cfe-commits mailing list