[PATCH] D84387: [AST][RecoveryExpr] Part4: Suppress spurious "err_typecheck_expect_scalar_operand" diagnostic

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 7 00:42:30 PDT 2020


hokein added a comment.

> I'm not sure I love having the assertion for contains-errors every place that handles dependent code in C.

My feeling is that the assertion would help for understanding the code (comparing with documenting it somewhere), and we don't have too many places.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84387/new/

https://reviews.llvm.org/D84387



More information about the cfe-commits mailing list