[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

Tue Oct 6 14:53:22 PDT 2020

JonasToth added a comment.

In D54943#2302315 <https://reviews.llvm.org/D54943#2302315>, @0x8000-0000 wrote:

> In D54943#2292377 <https://reviews.llvm.org/D54943#2292377>, @0x8000-0000 wrote:
>
>> In D54943#2291969 <https://reviews.llvm.org/D54943#2291969>, @JonasToth wrote:
>>
>>> @AlexanderLanin @0x8000-0000 i created the branch `release-11-const` (https://github.com/JonasToth/llvm-project/tree/release-11-const) in my fork.
>>>
>>> This branch is based on 11-rc3 and cherry picks the commits that correspond to this revision.
>>> I hope this is of any use for you! I will probably forget to update this branch all the time, but if I feel like there has been actual progress made, i will update!
>>
>> Thank you Jonas - will add this to our CI tool for the new project and try to find some time to run it on the legacy project.
>
> Just a quick update; in clang-tidy mode it works great, with no false positive and no crashes. I haven't tried the 'apply-replacements' mode.

That is great to hear! I update the `release-11-const` branch with the current state.

If you try the replacement-mode (with `run-clang-tidy`) beware, that there is a bug in the deduplication of clang-apply-replacements and some templated functions result in multiple applications of `const`.
This is something i need to work on, before everything can land :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54943/new/

https://reviews.llvm.org/D54943