[PATCH] D87451: add new option -mignore-xcoff-visibility

[David Tenty via Phabricator via cfe-commits]

daltenty added inline comments.


================
Comment at: clang/docs/ClangCommandLineReference.rst:2622
+
+Do not emit any visibility attribute for asm on AIX or give all symbols 'unspecified' visibility in xcoff object file (XCOFF only)
+
----------------
nit: plural. capitalization.


================
Comment at: clang/include/clang/Driver/Options.td:2566
+def mignore_xcoff_visibility : Flag<["-"], "mignore-xcoff-visibility">, Group<m_Group>,
+HelpText<"Not emit the visibility attribute for asm in AIX OS or give all symbols 'unspecified' visibility in xcoff object file">,
+  Flags<[CC1Option]>;
----------------



================
Comment at: llvm/lib/CodeGen/CommandFlags.cpp:340
+      cl::desc("Not emit the visibility attribute for asm in AIX OS or give "
+               "all symbols 'unspecified' visibility in xcoff object file"),
+      cl::init(false));
----------------
nit: capitalize XCOFF


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87451/new/

https://reviews.llvm.org/D87451