[PATCH] D88814: [clangd] Enable partial namespace matches for workspace symbols

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/FindSymbols.cpp:44
 
+// Returns true if \p Query can be found as a sub-scope inside \p Scope.
+bool approximateScopeMatch(llvm::StringRef Scope,
----------------
sammccall wrote:
> I had a little trouble following this...
> It seems a little simpler (fewer vars to track) if we avoid the up-front split on scopes.
> 
> ```
> assert(Scope.empty() || Scope.endswith("::")); // or handle in some way
> // Walk through Scope, consuming matching tokens from Query.
> StringRef First;
> while (!Scope.empty() && !Query.empty()) {
>   tie(First, Scope) = Scope.split("::");
>   if (Query.front() == First)
>     Query = Query.drop_front();
> }
> return Query.empty(); // all components of query matched
> ```
> 
> in fact we can avoid preprocessing query too:
> 
> ```
> // Query is just a StringRef
> assert(Scope.empty() || Scope.endswith("::")); // or handle in some way
> assert(Query.empty() || Query.endswith("::"));
> 
> // Walk through Scope, consuming matching tokens from Query.
> StringRef First;
> while (!Scope.empty() && !Query.empty()) {
>   tie(First, Scope) = Scope.split("::");
>   Query.consume_front(StringRef(First.data(), First.size() + 2) /*Including ::*/);
> }
> return Query.empty(); // all components of query matched
> ```
Yes but they would do different things. I believe the confusion is caused by usage of `sub-scope` without a clear definition.  The codes you've suggested are performing sub-sequence matches rather than sub-string(i.e. we are looking for a contigious segment in `Scope` that matches `Query`).

I believe a query of the form `a::c::` shouldn't be matched by `a::b::c::`. I can try simplifying the logic, but it would be nice to agree on the behaviour :D.

Sorry if I miscommunicated this so far.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88814/new/

https://reviews.llvm.org/D88814