[PATCH] D88789: [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592)

Mon Oct 5 14:56:51 PDT 2020

nikic added a comment.

This ended up having a rather large impact...

Compile-time: https://llvm-compile-time-tracker.com/compare.php?from=567462b48eba1c2d286ce97117994463f4535d2e&to=e00f189d392dd9bf95f6a98f05f2d341d06cd65c&stat=instructions
Code size: https://llvm-compile-time-tracker.com/compare.php?from=567462b48eba1c2d286ce97117994463f4535d2e&to=e00f189d392dd9bf95f6a98f05f2d341d06cd65c&stat=size-text
Largest code size impact is CMakeFiles/pairlocalalign.dir/constants.c.o with a code-size reduction of ~6%.

Always happy about compile-time improvements, but the large code size changes indicate that this has a pretty significant impact on optimization, and as usual it's hard to tell whether it's a good or a bad one :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88789/new/

https://reviews.llvm.org/D88789