[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

[Digger via Phabricator via cfe-commits]

DiggerLin added inline comments.


================
Comment at: clang/include/clang/Basic/CodeGenOptions.def:46
                                      ///< aliases to base ctors when possible.
-CODEGENOPT(DataSections      , 1, 0) ///< Set when -fdata-sections is enabled.
+CODEGENOPT(DataSections      , 1, 0) ///< Set by default, or when -f[no-]data-sections.
+CODEGENOPT(HasExplicitDataSections, 1, 0) ///< Set when -f[no-]data-sections is set.
----------------
DiggerLin wrote:
> turn on by default , it should be changed to CODEGENOPT(DataSections      , 1, 1) ?
> 
please  ignore above comment.  DataSection is set by default only on AIX OS . the comment maybe need to be modified?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88737/new/

https://reviews.llvm.org/D88737