[PATCH] D88789: [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592)

Mon Oct 5 12:36:59 PDT 2020

lebedev.ri added a comment.

In D88789#2312510 <https://reviews.llvm.org/D88789#2312510>, @lebedev.ri wrote:

> So, we can't really teach SCEV about this: D88788 <https://reviews.llvm.org/D88788> (not without the https://bugs.llvm.org/show_bug.cgi?id=47592 at least)
> And we can't recover the situation post-inlining in instcombine: D88842 <https://reviews.llvm.org/D88842>.
>
> It really does look like this fold is actively breaking
> otherwise-good IR, in a way that is not recoverable.
> And that means, this fold isn't helpful in exposing the passes
> that are otherwise unaware of these patterns it produces.
>
> I'm proceeding with this patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88789/new/

https://reviews.llvm.org/D88789