[PATCH] D88789: [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592)

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 5 12:34:21 PDT 2020


efriedma added a comment.

> Keeping loads and stores of pointers as pointers to the extent possible doesn't seem like a bad idea, but I'm worried people will feel like this gives a *semantic* guarantee that isn't really there. Fundamentally, LLVM still doesn't currently have typed memory. All of the optimizer is built upon this assumption.

LLVM currently isn't internally consistent.  See https://bugs.llvm.org/show_bug.cgi?id=34548 .  I should probably make a LangRef patch so the "pointer aliasing" section indicates there's an issue here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88789/new/

https://reviews.llvm.org/D88789



More information about the cfe-commits mailing list