[PATCH] D84226: [AST][RecoveryExpr] Part1: Support dependent binary operator in C for error recovery.

[Sam McCall via Phabricator via cfe-commits]

sammccall accepted this revision.
sammccall added inline comments.


================
Comment at: clang/lib/Sema/SemaExpr.cpp:14381
+          OpLoc, CurFPFeatureOverrides());
+    switch (Opc) {
+    case BO_Assign:
----------------
now the only thing that differs between the cases is the type. You could consider putting the type in a variable, and factoring the Create after the switch.


================
Comment at: clang/lib/Sema/SemaExpr.cpp:14393
+    case BO_NE:
+
+    case BO_LAnd:
----------------
(why the line break here)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84226/new/

https://reviews.llvm.org/D84226