[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

Sean Fertile via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 5 08:01:17 PDT 2020


sfertile added inline comments.


================
Comment at: clang/lib/Sema/SemaDecl.cpp:16447
+
+    bool AIXBitfieldViolation = false;
+    if (const BuiltinType *BTy = FieldTy.getTypePtr()->getAs<BuiltinType>()) {
----------------
Can  this change can be split out into its own patch? If it can i would suggest doing so.


================
Comment at: clang/test/Layout/aix-oversized-bitfield.cpp:1
+// RUN: %clang_cc1 -triple powerpc-ibm-aix-xcoff -fsyntax-only -verify %s
+
----------------
Is it possible to run this test as both C and C++?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87029/new/

https://reviews.llvm.org/D87029



More information about the cfe-commits mailing list